From owner-acpi-jp@jp.FreeBSD.org Fri Dec 19 06:04:57 2003
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) id hBIL4vF35937;
	Fri, 19 Dec 2003 06:04:57 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204])
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) with ESMTP/inet id hBIL4uC35932
	for <acpi-jp@jp.freebsd.org>; Fri, 19 Dec 2003 06:04:56 +0900 (JST)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 26674 invoked from network); 18 Dec 2003 20:58:14 -0000
Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63])
          (envelope-sender <jhb@FreeBSD.org>)
          by mail4.speakeasy.net (qmail-ldap-1.03) with AES256-SHA encrypted SMTP
          for <arch@freebsd.org>; 18 Dec 2003 20:58:14 -0000
Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4])
	by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id hBIKw9M0024577;
	Thu, 18 Dec 2003 15:58:09 -0500 (EST)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20031218155821.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20031218124754.O74387@root.org>
From: John Baldwin <jhb@freebsd.org>
To: Nate Lawson <nate@root.org>
Cc: acpi-jp@jp.FreeBSD.org, arch@freebsd.org
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
Date: Thu, 18 Dec 2003 15:58:21 -0500
X-Sequence: acpi-jp 2927
Subject: [acpi-jp 2927] RE: acpi_toshiba and acpi_asus drivers
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: jhb@FreeBSD.org
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+031216


On 18-Dec-2003 Nate Lawson wrote:
> I'm prepping/reworking some user-submitted drivers for import.  I'd like
> some comments on the directory structure.  The hardware both drive is
> everything from fans to hotkeys to lcd backlight.  Both are very
> hw-specific and do not conform to the ACPI spec although they do control
> their functions through ACPI.
> 
> The directory structure I'm currently working with is:
>     sys/i386/acpica/acpi_toshiba.c
>     sys/i386/acpica/acpi_asus.c
>     sys/modules/acpi_toshiba/Makefile
>     sys/modules/acpi_asus/Makefile
>     share/man/man4/acpi_toshiba.4
>     share/man/man4/acpi_asus.4
> 
> One alternative is to their modules under the acpi dir (e.g.,
> sys/modules/acpi/acpi_toshiba).  Also, the driver src could be
> sys/dev/acpi_toshiba.  However, a new dir for just one file seems a bit
> much.  My main concern is that as these drivers proliferate that we keep
> the dir structure neat.

Having a /sys/modules/acpi with acpi, acpi_toshiba, and acpi_asus in
them is probably a good idea.  Putting the files under sys/i386/acpica
is also probably ok.  Should the manpages be in man4.i386 rather than
man4 though?

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
