From owner-acpi-jp@jp.FreeBSD.org Wed Dec 24 05:53:10 2003
Received: (from daemon@localhost)
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) id hBNKrAO36013;
	Wed, 24 Dec 2003 05:53:10 +0900 (JST)
	(envelope-from owner-acpi-jp@jp.FreeBSD.org)
Received: from rootlabs.com (root.org [67.118.192.226])
	by castle.jp.FreeBSD.org (8.11.6p2+3.4W/8.11.3) with SMTP/inet id hBNKr9C36006
	for <acpi-jp@jp.freebsd.org>; Wed, 24 Dec 2003 05:53:09 +0900 (JST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 92460 invoked by uid 1000); 23 Dec 2003 20:53:03 -0000
From: Nate Lawson <nate@root.org>
To: John Baldwin <jhb@freebsd.org>
cc: acpi-jp@jp.FreeBSD.org, arch@freebsd.org
In-Reply-To: <XFMail.20031218155821.jhb@FreeBSD.org>
Message-ID: <20031223125146.K92457@root.org>
References: <XFMail.20031218155821.jhb@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: acpi-jp@jp.FreeBSD.org
Precedence: list
Date: Tue, 23 Dec 2003 12:53:03 -0800
X-Sequence: acpi-jp 2933
Subject: [acpi-jp 2933] RE: acpi_toshiba and acpi_asus drivers
Sender: owner-acpi-jp@jp.FreeBSD.org
X-Originator: nate@root.org
X-Distribute: distribute version 2.1 (Alpha) patchlevel 24e+031216

On Thu, 18 Dec 2003, John Baldwin wrote:
> On 18-Dec-2003 Nate Lawson wrote:
> > I'm prepping/reworking some user-submitted drivers for import.  I'd like
> > some comments on the directory structure.  The hardware both drive is
> > everything from fans to hotkeys to lcd backlight.  Both are very
> > hw-specific and do not conform to the ACPI spec although they do control
> > their functions through ACPI.
> >
> > The directory structure I'm currently working with is:
> >     sys/i386/acpica/acpi_toshiba.c
> >     sys/i386/acpica/acpi_asus.c
> >     sys/modules/acpi_toshiba/Makefile
> >     sys/modules/acpi_asus/Makefile
> >     share/man/man4/acpi_toshiba.4
> >     share/man/man4/acpi_asus.4
> >
> > One alternative is to their modules under the acpi dir (e.g.,
> > sys/modules/acpi/acpi_toshiba).  Also, the driver src could be
> > sys/dev/acpi_toshiba.  However, a new dir for just one file seems a bit
> > much.  My main concern is that as these drivers proliferate that we keep
> > the dir structure neat.
>
> Having a /sys/modules/acpi with acpi, acpi_toshiba, and acpi_asus in
> them is probably a good idea.  Putting the files under sys/i386/acpica
> is also probably ok.  Should the manpages be in man4.i386 rather than
> man4 though?

Ok, this is what I'll be committing:
sys/i386/acpica/acpi_toshiba.c
sys/i386/acpica/acpi_asus.c
sys/modules/acpi/acpi/Makefile
sys/modules/acpi/acpi_toshiba/Makefile
sys/modules/acpi/acpi_asus/Makefile
share/man/man4.i386/acpi_toshiba.4
share/man/man4.i386/acpi_asus.4

-Nate
